Require Python 3.8, update CI #752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems all 3.12 tests get stuck on a similar issue: |
Python 3.6 and 3.7 have both been end-of-life for over a year. This PR starts requiring Python 3.8 and higher for Solara. CI and test code is modified in sync.
for more information, see https://pre-commit.ci
|
It seems it just isn't installed when imported here: Line 5 in 4647131 Weird that it happens on 3.12 only. But where should I specify it as an required package or install it? |
|
More complex than I thought, and unfortunately no time to debug it. Closing. (I would still recommend dropping Python 3.6 and 3.7) |
|
It is weird, python-dotenv is a dependency. Might pick up the wrong Python env? I'd rather extend the Python versions, and only drop the older ones if there are strong reasons (we saw Python 3.6 envs in our consultancy work, and we couldn't do the work if we didn't support it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 and 3.7 have both been end-of-life for over a year. This PR starts requiring Python 3.8 and higher for Solara. CI and test code is modified in sync.